Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add next_event_prequeue_start_time and next_event_start_time #878

Merged
merged 1 commit into from May 11, 2022

Conversation

broswen
Copy link
Contributor

@broswen broswen commented May 10, 2022

  • Add next_event_prequeue_start_time and next_event_start_time to Waiting Room.

  • Use time.Time pointer for nullable Waiting Room Event prequeue_start_time property.

Description

The waiting room schema now exposes the prequeue start time and start time of the next event or the event that is currently in progress.
This is not documented in the official API yet.

The prequeue_start_time property on WaitingRoomEvent should be a pointer. It is optional and if not specified should serialize to null.
I think switching to a pointer might be a breaking change, especially for the Terraform provider.

Has your change been tested?

Updated unit tests and pass.
Tested with real resources using the API.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@jacobbednarz
Copy link
Member

realistically, we should only be using *time.Time (the next major release will likely only use pointers for all fields) so I'm happy to fix that here. the change is internal to Terraform so 👍 from me.

let's wait for the public documentation though to ensure this endpoint is fully documented before getting too fair ahead of ourselves.

@broswen
Copy link
Contributor Author

broswen commented May 11, 2022

realistically, we should only be using *time.Time (the next major release will likely only use pointers for all fields) so I'm happy to fix that here. the change is internal to Terraform so +1 from me.

let's wait for the public documentation though to ensure this endpoint is fully documented before getting too fair ahead of ourselves.

Public documentation is live. Visible on the Object Definition. https://api.cloudflare.com/#waiting-room-list-waiting-rooms

@jacobbednarz jacobbednarz merged commit 1f43607 into cloudflare:master May 11, 2022
@jacobbednarz
Copy link
Member

awesome! thank you @broswen 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants